[PATCH v2 10/14] make dwarf_expr_frame_base_1 public

Eli Zaretskii eliz@gnu.org
Mon Jun 23 14:57:00 GMT 2014


> Date: Mon, 23 Jun 2014 09:18:15 +0100
> From: Gary Benson <gbenson@redhat.com>
> Cc: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
> 
> > > 2014-06-20  Tom Tromey  <tromey@redhat.com>
> > >
> > >         * dwarf2loc.h (dwarf_expr_frame_base_1): Declare.
> > >         * dwarf2loc.c (dwarf_expr_frame_base_1): Now public.
> > 
> > [apologies for the repeat ... curse you gmail ...]
> > 
> > Can you remove the _1?
> > (renaming it as needed)
> > I see the non _1 version is also static, so some reasonable renaming
> > (perhaps of both) should be simple enough.
> 
> Is there some convention about what "_1" means in a function name?

In most, if not all, cases I saw those are internal subroutines of the
sans-_1 peers.



More information about the Gdb-patches mailing list