[PATCH 0/7] more constification

Pedro Alves palves@redhat.com
Thu Jun 12 13:04:00 GMT 2014


On 06/11/2014 07:53 PM, Tom Tromey wrote:
> This series constifies a few more things in gdb.
> 
> A few of the patches are very basic and #4 is downright trivial.
> 
> Patch #6 casts away const in a couple spots.  There's a justification
> in the patch; but I also wanted to add that the casts only affect
> mdebugread.c, which can't really be said to be actively maintained in
> any case.
> 
> Some of these patches are part of a larger work to constify the
> argument pass to gdb commands.  This longer series isn't finished yet;
> but it simplifies to the work to put patches in bottom-up and mildly
> improves gdb in the process.

Looked fine to me.

A couple nits I noticed:

 - The subject of patch #3 sounds like something you'd have
   in a local branch.  Should that patch be merged with some
   other in the series?  Does GDB build at each step of the
   series?

 - A typo in the log of patch #6: "SO".

-- 
Pedro Alves



More information about the Gdb-patches mailing list