[PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4
Siva Chandra
sivachandra@google.com
Wed Jun 4 20:53:00 GMT 2014
On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/04/2014 07:05 PM, Siva Chandra wrote:
>> Does the attached patch fix the issue pointed out by Ulrich Weigand
>> here: https://sourceware.org/ml/gdb-patches/2014-06/msg00169.html
>>
>> ChangeLog
>> 2014-06-04 Siva Chandra Reddy <sivachandra@google.com>
>>
>> * python/py-xmethods.c (invoke_match_method)
>> (gdbpy_get_matching_xmethod_workers, gdbpy_get_xmethod_arg_types):
>> Cast the second arg to PyObject_GetAttrString and
>> PyObject_GetAttrString to char *.
>>
>
> How about we handle this in a central place, like Py_DECREF is
> handled ? See python-internal.h.
This breakage was marked as "nice to have it fixed" for 7.8.
Considering that, do you prefer that we have a Py_DECREF like solution
now, or after 7.8 branching?
More information about the Gdb-patches
mailing list