[PATCH, doc RFA] Split create-breakpoint! into make-breakpoint, register-breakpoint!

[Ludovic Courtès]

Doug Evans <xdje42@gmail.com> skribis:

> In keeping with the splitting of object creation and registration into
> two separate pieces, this does the same for breakpoints.
> "Consistency Is Good".

That makes sense.

> There hasn't been an FSF release of gdb+guile yet so I think it's ok
> to remove create-breakpoint! here.

Yup.

> 2014-06-03  Doug Evans  <xdje42@gmail.com>
>
> 	* guile/scm-breakpoint.c (struct gdbscm_breakpoint_object): New members
> 	is_scheme_bkpt, spec.
> 	(bpscm_make_breakpoint_smob): Initialize new members.
> 	(gdbscm_create_breakpoint_x): Split into two ...
> 	(gdbscm_make_breakpoint, gdbscm_register_breakpoint_x): New functions.
> 	(bpscm_breakpoint_deleted): Reset breakpoint number and stop function.
> 	(scheme_function breakpoint_functions): Update.
>
> 	testsuite/
> 	* gdb.guile/scm-breakpoint.exp: Update.
> 	Add tests for breakpoint registration.
>
> 	doc/
> 	* guile.texi (Breakpoints In Guile): Update.

LGTM.

Ludo’.