[PATCH] gdb/source.c: Fix matching path substitute rule listing

Joel Brobecker brobecker@adacore.com
Tue Jun 3 14:25:00 GMT 2014


> This was tested on x86_64 Linux 3.0.0-21
> 
> gdb/ChangeLog:
> 
>     * source.c (show_substitute_path_command): Fix display of matching
>     substitution rules
> 
> gdb/testsuite/ChangeLog:
> 
>     * subst.exp: Add tests to verify partial path matching output

Thank you. This is mostly OK. I made the following little fixes:
  - In the ChangeLog, the sentences should all end with a period.
  - In the second ChangeLog, the patch to the file being changed
    should be relative to the directory where the ChangeLog is
    (missing "gdb.ada/" in this case).
  - For the platform on which this was tested, I couldn't tell what
    the 3.0.0-21 was about (kernel version?), but that part is usually
    not significant and often omitted, so I just removed it.
    I've also moved that information after the ChangeLog entries
    as we traditionally place it there, but that's just because
    I was already making minor edits. There are otherwise no requirement
    for the placement of that information.

I've pushed the attached commit under the "tiny patch" rule. There
are only so much code we'll be able to accept from you under that
rule, so if you think you might have other contributions coming,
you'll need to have a copyright assignment on file with the FSF
(it's a bit of a lengthy process, even if they seem to have improved
in the past).

Thanks again for the patch (and your patience!).
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-source.c-Fix-matching-path-substitute-rule-listi.patch
Type: text/x-diff
Size: 4500 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20140603/a3d2ce2e/attachment.bin>


More information about the Gdb-patches mailing list