[PATCH] infcmd.c (attach_command): Improve comment.

Doug Evans dje@google.com
Tue Jul 29 21:48:00 GMT 2014


I always have to re-lookup what target_attach_no_wait means,
and what targets set it to non-zero, every time I look at this code.

This patch is a modest attempt at clearing things up for me.
[maybe a good example of why double negatives should be avoided,
in this case "! no-wait".  maybe not.]

2014-07-29  Doug Evans  <dje@google.com>

	* infcmd.c (attach_command): Improve comment.

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index d84c591..1def6cd 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2578,7 +2578,7 @@ attach_command (char *args, int from_tty)
   /* Some system don't generate traps when attaching to inferior.
-     E.g. Mach 3 or GNU hurd.  */
+     E.g. Mach 3 or GNU hurd.  Skip waiting for these targets.  */
   if (!target_attach_no_wait)
       struct inferior *inferior = current_inferior ();

More information about the Gdb-patches mailing list