[PATCH 00/13] Include some headers in common-defs.h

Gary Benson gbenson@redhat.com
Tue Jul 29 15:11:00 GMT 2014

Hi all,

This series builds on my "config.h rationalization" series that is
currently under review [1].

Each patch adds one #include line to common-defs.h and removes all
other inclusions of that file in all files that include either defs.h
or server.h.  Patches 1-11 deal with files that are already included
by both defs.h and server.h; these patches don't really change
anything about the build.  Patches 12 and 13 add gdb_assert.h and
string.h respectively.  These are included by server.h but not by
defs.h, but both are included in hundreds of files so I think they
are good candidates for global inclusion.

There are three more files that are included by both defs.h and
server.h that I have not dealt with in this series.  errno.h and
alloca.h are both handled completely differently by defs.h and
server.h: moving these headers to common-defs.h should be done, but
will require merging the configury.  The final file, print-utils.h,
is included indirectly by both defs.h and server.h but cannot be
merged without some of the "Common code cleanups" series [2].  That
needs some rewriting, so I'll add that to common-defs.h as part of
the next version of that series.

Is this ok to commit?


[1] https://sourceware.org/ml/gdb-patches/2014-07/msg00670.html
[2] https://sourceware.org/ml/gdb-patches/2014-07/msg00427.html

More information about the Gdb-patches mailing list