[PATCH] properly parenthesize two macros

Tom Tromey tromey@redhat.com
Fri Jul 25 16:02:00 GMT 2014


I happened to notice that a couple of macros in target.h weren't
properly using parens and as a result had a strange definition.

This patch adds the parens and then fixes the macros to be written as
must have been intended.

Tested by rebuilding.
I'm pushing this as obvious.

2014-07-25  Tom Tromey  <tromey@redhat.com>

	* target.h (target_stopped_data_address)
	(target_watchpoint_addr_within_range): Use "->", not ".".  Fix
	parentheses.
---
 gdb/ChangeLog | 6 ++++++
 gdb/target.h  | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/target.h b/gdb/target.h
index bcf97d9..29a1f01 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1822,12 +1822,12 @@ extern int target_ranged_break_num_registers (void);
    target_stopped_by_watchpoint, in such case place it to *ADDR_P.  Only the
    INFERIOR_PTID task is being queried.  */
 #define target_stopped_data_address(target, addr_p) \
-    (*target.to_stopped_data_address) (target, addr_p)
+    (*(target)->to_stopped_data_address) (target, addr_p)
 
 /* Return non-zero if ADDR is within the range of a watchpoint spanning
    LENGTH bytes beginning at START.  */
 #define target_watchpoint_addr_within_range(target, addr, start, length) \
-  (*target.to_watchpoint_addr_within_range) (target, addr, start, length)
+  (*(target)->to_watchpoint_addr_within_range) (target, addr, start, length)
 
 /* Return non-zero if the target is capable of using hardware to evaluate
    the condition expression.  In this case, if the condition is false when
-- 
1.9.3



More information about the Gdb-patches mailing list