[PATCH] Handle OP_STRING in dump_subexp_body_standard

Joel Brobecker brobecker@adacore.com
Tue Jul 15 15:18:00 GMT 2014


> >>> gdb/ChangeLog:
> >>>
> >>> 2014-06-19  Simon Marchi  <simon.marchi@ericsson.com>
> >>>
> >>> 	* expprint.c (dump_subexp_body_standard): Handle OP_STRING.
[...]
> > So, I would say that it should be "elt + 1" for variable "type".
> 
> You are totally right.
> 
> >>> +	/* Skip string content. */
> >>> +	elt += BYTES_TO_EXP_ELEM(len);
> > 
> > Missing space before '('.
> 
> Ack.
> 
> Thanks for the review. Do these small fixes warrant a v2?

OK, pre-approved with the changes above, but our procedures do require
you to re-post a patch whenever what's committed is different from
what was originally posted. I'd say, make the modifications, test them,
commit & push, and then reply to this thread with the updated patch.

Thank you,
-- 
Joel



More information about the Gdb-patches mailing list