[PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c
Fri Jul 11 15:38:00 GMT 2014
>>>>> "Gary" == Gary Benson <firstname.lastname@example.org> writes:
Gary> -#ifdef GDBSERVER
Gary> -#include "server.h"
Gary> -#include "defs.h"
Gary> -#include "inferior.h"
Gary> +#include "common-utils.h"
>> I think this should include config.h first.
Gary> common-utils.h includes it. Or did you mean the gnulib one?
Nope, not the gnulib one. I didn't realize that common-utils.h includes
config.h. That seems weird to me.
I think it's generally better for "random" headers not to include
config.h and to either have a "standard" base header (like defs.h or
server.h) that includes config.h, or to just have explicit includes of
config.h as the first thing in each .c.
I realize it's not a problem arising from your series.
But would you mind just having the .c include config.h explicitly?
Then at some point I'll go through and fix up common-utils.h and its
More information about the Gdb-patches