[PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description

Pedro Alves alves.ped@gmail.com
Wed Jul 9 13:07:00 GMT 2014

On 06/27/2014 03:12 PM, Gary Benson wrote:
> This commit merges i386_ and amd64_linux_read_description, renaming
> both to x86_linux_read_description.
> This patch differs from the original version in this series
> in that x86_linux_read_description is much cleaner, having
> been rewritten to avoid "#ifdef spaghetti".
> gdb/
> 2014-06-27  Gary Benson  <gbenson@redhat.com>
> 	* amd64-linux-nat.c (amd64_linux_read_description): Renamed to
> 	x86_linux_read_description.  All uses updated.  amd64-specific
> 	code conditionalized.  Conditionalized i386-specific code added.
> 	Redundant cast removed.
> 	* i386-linux-nat.c (i386_linux_read_description): Renamed to
> 	x86_linux_read_description.  All uses updated.  i386-specific
> 	code conditionalized.  Conditionalized amd64-specific code added.
> 	One sizeof replaced with the actual type it is describing.

I compared the old vs new files side by side to try to check that
the merged code behaved the same the as before.  This version does
look much cleaner.

Looks good to me, thanks.

Pedro Alves

More information about the Gdb-patches mailing list