[PATCH] PR python/16699: GDB Python command completion with overriden complete vs. completer class

[Sergio Durigan Junior]

On Tuesday, July 08 2014, Jan Kratochvil wrote:

> Hi Sergio,
>
> the testcase FAILs with "read1" from:
> 	reproducer for races of expect incomplete reads
> 	http://sourceware.org/bugzilla/show_bug.cgi?id=12649
>
> Additionally the testcase uses $objdir instead of [standard_output_file],
> filed for it now tracking PR:
> 	$objdir and $subdir should be tainted
> 	https://sourceware.org/bugzilla/show_bug.cgi?id=17129

On Tuesday, July 08 2014, Jan Kratochvil wrote:

> On Tue, 08 Jul 2014 17:32:21 +0200, Jan Kratochvil wrote:
>> -    -re "^completefilecommandcond ${objdir}/${subdir}/py-completion-t$" {
>> +    -re "^completefilecommandcond ${completion_regex}$" {
>
> There was a racy bug here - and even in the former test - here should be:
>   +    -re "^completefilecommandcond ${completion_regex}\007$" {
>
> Updated fix attached.

Hello Jan,

Thank you for the catches.  I will update my local version.

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/