[PATCH] Assign 'targerr' instead of 'targ' to gdb_stdtargerr.

Marc Khouzam marc.khouzam@ericsson.com
Wed Jul 2 19:14:00 GMT 2014


Hi,

I noticed this what-seems-to-be-typo when browsing the code.
I'm not sure if the target can have two distinct streams or not 
but the code seems to think so.  I figure might as well fix it.
The original suspicious code was introduced at the same time as when
saved_output.targerr was added, so it really does look like a typo.
It was in commit 8d4d924b.

Is this ok?

Thanks


2014-07-02  Marc Khouzam  <marc.khouzam@ericsson.com>

    * cli/cli-logging.c (pop_output_files): Assign targerr to
    gdb_stdtargerr.

diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index ca2d76e..aae0039 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -171,7 +171,7 @@ pop_output_files (void)
       gdb_stderr = saved_output.err;
       gdb_stdlog = saved_output.log;
       gdb_stdtarg = saved_output.targ;
-      gdb_stdtargerr = saved_output.targ;
+      gdb_stdtargerr = saved_output.targerr;
     }
 
   saved_output.out = NULL;
-- 
1.7.9.5



More information about the Gdb-patches mailing list