[RFC 28/32] convert to_get_section_table

Tom Tromey tromey@redhat.com
Tue Jan 14 19:29:00 GMT 2014


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Looks fine to me.
>> - struct target_section_table *(*to_get_section_table) (struct
>> target_ops *);
>> + struct target_section_table *(*to_get_section_table) (struct
>> target_ops *)
>> +      TARGET_DEFAULT_RETURN (0);

Pedro> (I noticed now that methods that return a pointer could
Pedro>  say 'TARGET_DEFAULT_RETURN (NULL)' instead of 0.  I'm guessing
Pedro> you wrote 0 in the previous version where TARGET_DEFAULT
Pedro> would require a digit.)

Yeah.  Unfortunately I didn't think of this early enough.  I can fix
this if you like, but unlike other rewrites, I'd prefer to do it as a
cleanup patch on top.  I found the hard way that modifications to these
lines cause conflicts to bubble up through the entire patch series.

Tom



More information about the Gdb-patches mailing list