Looks fine to me. The patch is fine with me as is, but I'll note that I don't think there's any need for exec_set_find_memory_regions nowadays. Seems to me that exec_ops.to_find_memory_regions could always be set to objfile_find_memory_regions unconditionally. -- Pedro Alves