[PATCH] Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983

Tom Tromey tromey@redhat.com
Mon Jan 6 16:14:00 GMT 2014


>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:

>> solib-spu.c:spu_bfd_open
>> spu-linux-nat.c:spu_bfd_open

Hui> These two functions have used xstrdup, for example:

Oops, yeah.  Thanks.

Hui> 2014-01-06  Hui Zhu  <hui@codesourcery.com>
Hui> 	* gdb_bfd.c (gdb_bfd_stash_filename): Removed.
Hui> 	(gdb_bfd_open): Removed gdb_bfd_stash_filename.
Hui> 	(gdb_bfd_fopen): Ditto.
Hui> 	(gdb_bfd_openr): Ditto.
Hui> 	(gdb_bfd_openw): Ditto.
Hui> 	(gdb_bfd_openr_iovec): Ditto.
Hui> 	(gdb_bfd_fdopenr): Ditto.
Hui> 	* gdb_bfd.h (gdb_bfd_stash_filename): Removed.
Hui> 	* solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename
Hui> 	with xstrdup.
Hui> 	* solib-darwin.c (darwin_bfd_open): Alloc res->filename
Hui> 	with xstrdup.
Hui> 	* symfile-mem.c (symbol_file_add_from_memory): Removed
Hui> 	gdb_bfd_stash_filename.

This is ok.

Tom



More information about the Gdb-patches mailing list