[PATCH v5 08/15] vla: support for DW_AT_count
Joel Brobecker
brobecker@adacore.com
Fri Feb 28 16:53:00 GMT 2014
> 2013-11-19 Sanimir Agovic <sanimir.agovic@intel.com>
> Keven Boell <keven.boell@intel.com>
>
> * dwarf2read.c (read_subrange_type): Convert DW_AT_count to a dynamic
> property and store it as the high bound and flag the range accordingly.
> * gdbtypes.c (resolve_dynamic_bounds): If range is flagged as
> RANGE_UPPER_BOUND_IS_COUNT assign low + high - 1 as the new high bound.
> * gdbtypes.h (enum range_flags): New enum.
> (struct range_bounds): Add flags member.
Overall, the patch looks OK to me, but I'd rather we be consistent
with what we've been doing with other type flags, and use a bitfield
instead. I think that'll simplify your patch a bit.
--
Joel
More information about the Gdb-patches
mailing list