[RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only.

Mark Wielaard mjw@redhat.com
Wed Feb 26 10:53:00 GMT 2014


On Fri, 2014-02-21 at 19:42 +0100, Joel Brobecker wrote:
> Attached is the latest version of the patch.
> 
> I implemented the complaint, and then reverted it, for reasons that
> I explained in the added comment inside the new attr_value_as_address
> function. Basically, I don't want to be doing extra work as well as
> pessimize this function's number of arguments just for a very rare
> case of broken compiler.

Obviously I would like lots of screaming and yelling here (and the
function/argument will probably be inlined anyway, so I don't think the
extra argument passing will actually hurt that much, but that is
speculation). I do understand gdb isn't a DWARF-linter, and how you do
things is more in line with the "be liberal in what you accept"
principle.

No complaints (pun intended) to this patch.

Cheers,

Mark



More information about the Gdb-patches mailing list