[PATCH] guile: Add 'history-push!' procedure
Eli Zaretskii
eliz@gnu.org
Thu Feb 20 16:28:00 GMT 2014
> From: ludo@gnu.org (Ludovic Courtès)
> Cc: gdb-patches@sourceware.org, xdje42@gmail.com
> Date: Wed, 19 Feb 2014 22:43:43 +0100
>
> >> +@deffn {Scheme Procedure} history-push! value
> >> +Push @var{value}, an instance of @code{<gdb:value>}, to @value{GDBN}'s
> >> +value history.
> >
> > I think we should explain what "push" means in this context. It is
> > not self-evident.
>
> Right. How about s/push/append/? (In the procedure name as well.)
Fine with me.
> >> Return its index in the history, or @code{#f} if it is
> >> +not saved.
> >
> > Why would it not be saved?
>
> Good question. The doc above ârecord_latest_valueâ mentions that it can
> return -1, but I see no path leading to that. Can I assume that -1 is
> never returned?
I don't know, but if that is your reading, I see no reason not to.
> How about simply this:
>
> Using this function is useful to provide convenient access to values
> manipulated by a Guile extension of GDB.
I suggest
Putting into history values returned by Guile extensions will allow
the user convenient access to those values via CLI history
facilities.
Thanks.
More information about the Gdb-patches
mailing list