PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call
Joel Brobecker
brobecker@adacore.com
Wed Feb 19 07:59:00 GMT 2014
> Hi.
> Sorry for the delay!
No, Thank You for looking into it! :)
> I spent some time looking for a cleverer patch, but in the end I think the
> simplicity of this patch is nice.
:)
>
> 2014-02-18 lin zuojian <manjian2006@gmail.com>
> Joel Brobecker <brobecker@adacore.com>
> Doug Evans <xdje42@gmail.com>
>
> PR symtab/16581
> * dwarf2read.c (struct die_info): New member in_process.
> (reset_die_in_process): New function.
> (process_die): Set it at the start, reset when returning.
> (inherit_abstract_dies): Only call process_die if origin_child_die
> not already being processed.
>
> testsuite/
> * gdb.dwarf2/dw2-icycle.S: New file.
> * gdb.dwarf2/dw2-icycle.c: New file.
> * gdb.dwarf2/dw2-icycle.exp: New file.
That looks good to me, with one tiny little CS comment (see below).
> +static void
> +reset_die_in_process (void *arg)
> +{
> + struct die_info *die = arg;
> + die->in_process = 0;
Missing empty line after local variable declaration.
Thanks again,
--
Joel
More information about the Gdb-patches
mailing list