[ping] RE: [PATCH v1 1/3] Add AVX512 registers support to GDB.
Sturm, Michael
michael.sturm@intel.com
Fri Feb 14 12:38:00 GMT 2014
Ping...any feedback besides the feedback that Eli and Pedro gave?
Original patch series:
https://sourceware.org/ml/gdb-patches/2013-12/msg00817.html
https://sourceware.org/ml/gdb-patches/2013-12/msg00818.html
https://sourceware.org/ml/gdb-patches/2013-12/msg00819.html
https://sourceware.org/ml/gdb-patches/2013-12/msg00820.html
Feedback by Eli
https://sourceware.org/ml/gdb-patches/2013-12/msg00821.html
Feedback by Pedro
https://sourceware.org/ml/gdb-patches/2013-12/msg00848.html
Thanks and Regards,
Michael
-----Original Message-----
From: Pedro Alves [mailto:palves@redhat.com]
Sent: Friday, December 20, 2013 6:29 PM
To: Sturm, Michael
Cc: eliz@gnu.org; mark.kettenis@xs4all.nl; Tedeschi, Walfred; gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.
Hi there,
I skimmed this (not a real review), and noticed:
> +send_gdb "print have_avx512 ()\r"
> +gdb_expect {
Please use gdb_test_multiple instead of send_gdb/gdb_expect.
> + -re ".. = 1\r\n$gdb_prompt " {
> + pass "check whether processor supports AVX512"
> + }
> + -re ".. = 0\r\n$gdb_prompt " {
Should be a pass too:
pass "check whether processor supports AVX512"
As the test did its job.
> + }
> + -re ".*$gdb_prompt $" {
> + fail "check whether processor supports AVX512"
> + }
> + timeout {
> + fail "check whether processor supports AVX512 (timeout)"
> + }
These last two won't be necessary then.
> +}
> +
This:
> + verbose "processor does not support AVX512; skipping AVX512 tests"
> + return
should probably instead be:
unsupported "processor does not support AVX512; skipping AVX512 tests"
...
> +}
> \ No newline at end of file
Please add one.
--
Pedro Alves
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
More information about the Gdb-patches
mailing list