[PATCH v2 01/36] Guile extension language: configure changes
Joel Brobecker
brobecker@adacore.com
Mon Feb 10 10:23:00 GMT 2014
Hi Doug,
> +AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing)
[...]
> +AC_DEFUN([AC_TRY_LIBGUILE],
> +[
> + pkg_config=$1
> + guile_version_list=$2
> + flag_errors=$3
> + define([have_libguile_var],$4)
> + if test "${pkg_config}" = "missing"; then
> + AC_ERROR(pkg-config program not found)
> + fi
> + if test ! -f "${pkg_config}"; then
> + AC_ERROR(pkg-config program ${pkg_config} not found)
> + fi
I don't think we should error if pkg-config was not found and --with-guile
was left to "auto". This is going to break the build of many of us
who work on systems that don't have that tool installed (I've just
noticed that on Windows). Intead, let's disable guile support
when that happens.
For the second error, I think we should apply the same principle.
Can you adjust that part, please?
Thank you,
--
Joel
More information about the Gdb-patches
mailing list