[commit/Ada] Add missing call to obstack_init for ada-lang.c::cache_space

Joel Brobecker brobecker@adacore.com
Mon Feb 10 09:00:00 GMT 2014


Hello,

This bit was meant to be merged with the following patch:

    commit 3d9434b5ddc141178be232048e3d944955cc1f91
    Subject: [Ada] Add a symbol lookup cache

... but I forgot :-(. This causes the cache to be undefined, and
with a bit of (bad) luck:

    % gdb
    (gdb) set lang ada
    (gdb) set $xxx := 1
    [SEGV]

gdb/ChangeLog:

        * ada-lang.c (_initialize_ada_language): Initialize
        cache_space obstack.

Tested (again) on x86_64-linux, and pushed.

Sorry about that!
-- 
Joel

---
 gdb/ChangeLog  | 5 +++++
 gdb/ada-lang.c | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 828cb6e..7a51617 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2014-02-10  Joel Brobecker  <brobecker@adacore.com>
 
+	* ada-lang.c (_initialize_ada_language): Initialize
+	cache_space obstack.
+
+2014-02-10  Joel Brobecker  <brobecker@adacore.com>
+
 	* ada-lang.c (HASH_SIZE): New macro.
 	(struct cache_entry): New type.
 	(cache_space, cache): New static globals.
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index fc2c83b..a4accac 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -13493,6 +13493,7 @@ DWARF attribute."),
      NULL, NULL, &maint_set_ada_cmdlist, &maint_show_ada_cmdlist);
 
   obstack_init (&symbol_list_obstack);
+  obstack_init (&cache_space);
 
   decoded_names_store = htab_create_alloc
     (256, htab_hash_string, (int (*)(const void *, const void *)) streq,
-- 
1.8.3.2



More information about the Gdb-patches mailing list