[PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence
Joel Brobecker
brobecker@adacore.com
Fri Feb 7 10:27:00 GMT 2014
Hello!
> 2013-11-26 Sanimir Agovic <sanimir.agovic@intel.com>
> Keven Boell <keven.boell@intel.com>
>
> * findvar.c (default_read_var_value): Resolve dynamic bounds if location
> points to a constant blob.
Small trivial comment....
> case LOC_CONST_BYTES:
> + if (is_dynamic_type (type))
> + /* Value is a constant byte-sequence and needs no memory access. */
> + type = resolve_dynamic_type (type, /* Unused address. */ 0);
Although not required by C, we prefer in the GDB project to still
use curly braces around the if block. The reason is that the comment
visually looks like a statement, so it looks like the if block as
more than one statement, hence the use of curly braces...
Thank you!
--
Joel
More information about the Gdb-patches
mailing list