[PATCH 1/5] libthread_db: debug output should go to gdb_stdlog

Yao Qi yao@codesourcery.com
Wed Dec 17 14:09:00 GMT 2014


Pedro Alves <palves@redhat.com> writes:

> Let me answer that by adding a comment.  Does this make it clearer?

Yes, it is clearer....

>
>   if (*libthread_db_search_path || libthread_db_debug)

... and it is also important to exchange them in the condition.

>     {
>       struct ui_file *file;
>       const char *library;
>
>       library = dladdr_to_soname (*info->td_ta_new_p);
>       if (library == NULL)
> 	library = LIBTHREAD_DB_SO;
>
>       /* If we'd print this to gdb_stdout when debug output is
> 	 disabled, still print it to gdb_stdout if debug output is
> 	 enabled.  User visible output should not depend on debug
> 	 settings.  */

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list