[PATCH 4/4 v6] Introduce common-debug.h

Pedro Alves palves@redhat.com
Wed Aug 20 15:51:00 GMT 2014


On 08/13/2014 12:52 AM, Doug Evans wrote:
> btw, it's confusing that the variable is named "debug_hw_points"
> but the command to set it is "maint set show-debug-regs".  Bleah.
> The intuitive naming is to base the variable name off of the parameter name,
> but I'm also ok with changing the parameter name.
> "set debug hw-points <n>" ?
> I don't have a strong opinion, other than if we're making changes
> in this area IWBN to clean up the naming while we're at it.
> Plus "set debug ..." is more consistent with other such parameters
> than "maint set ...".

FWIW, if I don't use this command for a while, when I need it again,
I always get confused with the set+show in "maint SET SHOW-debug-regs".

I'd +1 renaming it to "set debug something".

(TBC, I'm not suggesting that doing this now.)

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list