[PATCH 4/5 v7] Introduce common-debug.h

Frank Ch. Eigler fche@redhat.com
Wed Aug 20 13:32:00 GMT 2014


Hi -


> > [...]
> > i'm fine with updating sim/common/sim-trace.h with that idea:
> > #define debug_printf sim_debug_printf
> > all the symbols coming out of the sim really should be namespaced

IMHO, names this generic should be avoided in *both* application (gdb)
and library (sim), lest another future library come & interfere later.


> Great.  I can put together a patch if you like (or I can make the
> change, or you can... whatever's easiest!)  I don't know much about
> SIM... is there a list to mail patches to?  And, is its upstream
> repo the same as binutils+GDB or is it imported from somewhere else
> like libiberty?

sim is part of the binutils-gdb.git repo, patches here fine.  The main
problem with testing the sim for changes like this is its inability to
easily build all targets, and its aggressive use of macros, which
makes it hard to know you've actually covered all the cases for a
symbol-rename.

- FChE



More information about the Gdb-patches mailing list