[PATCH v2] Fix xmethod Python so that it works with Python 3

Doug Evans dje@google.com
Thu Aug 14 22:35:00 GMT 2014


Siva Chandra writes:
 > The attached patch fixes the "no space before parenthesis in Python"
 > comment by Joel. The comment was for the changes in the test suite.
 > Going by examples, I thought the test case code (but not the .exp
 > files) did not require adherence to coding style.
 > 
 > I also agree with Joel that this patch should also pushed to the 7.8 branch.
 > 
 > ChangeLog:
 > 2014-08-14  Siva Chandra Reddy  <sivachandra@gmail.com>
 > 
 > gdb/
 > 
 >         * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the
 >         'items' methods instead of 'iteritems' method on dictionaries.
 > 
 > gdb/testsuite/
 > 
 >         * gdb.python/py-xmethods.py (A_getarrayind)
 >         (E_method_char_worker.__call__, E_method_int_worker.__call__):
 >         Use 'print' with function call syntax.
 >         (E_method_matcher.match): Fix tab vs space indentation mixup.

LGTM



More information about the Gdb-patches mailing list