Warnings in native MinGW32 build of GDB 7.8

Eli Zaretskii eliz@gnu.org
Sat Aug 9 14:10:00 GMT 2014


I've built today a native MinGW32 GDB 7.8, and saw warnings about
incomplete argument types:

     In file included from defs.h:631,
		      from gdb.c:19:
     gdbarch.h:429: warning: parameter has incomplete type
     gdbarch.h:430: warning: parameter has incomplete type

     In file included from target-dcache.h:21,
		      from target-dcache.c:19:
     dcache.h:42: warning: parameter has incomplete type

I fixed that as below, but I wonder why no one else saw this.  is this
because I use an ancient version of GCC?

OK to commit the below (master and 7.8 branch), with suitable
ChangeLog entries?

--- gdb/dcache.c~0	2014-07-29 15:37:42.000000000 +0300
+++ gdb/dcache.c	2014-08-09 16:17:31.823000000 +0300
@@ -18,6 +18,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+#include "target.h"	/* for 'enum target_xfer_status' */
 #include "dcache.h"
 #include "gdbcmd.h"
 #include <string.h>

--- gdb/defs.h~0	2014-07-29 15:37:42.000000000 +0300
+++ gdb/defs.h	2014-08-09 15:33:59.666750000 +0300
@@ -628,6 +628,7 @@
 #endif /* alloca not defined */
 
 /* Dynamic target-system-dependent parameters for GDB.  */
+#include "frame.h"	/* for 'struct frame_id' */
 #include "gdbarch.h"
 
 /* * Maximum size of a register.  Something small, but large enough for

--- gdb/target-dcache.c~0	2014-06-11 19:34:41.000000000 +0300
+++ gdb/target-dcache.c	2014-08-09 16:17:42.244875000 +0300
@@ -16,6 +16,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+#include "target.h"	/* for 'enum target_xfer_status' */
 #include "target-dcache.h"
 #include "gdbcmd.h"
 #include "progspace.h"



More information about the Gdb-patches mailing list