[PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf
Gary Benson
gbenson@redhat.com
Thu Aug 7 09:22:00 GMT 2014
Doug Evans wrote:
> Gary Benson writes:
> > +/* A stdarg wrapper for debug_vprintf. */
> > +
> > +static void ATTRIBUTE_PRINTF (1, 2)
> > +debug_agent_print (const char *fmt, ...)
>
> Nit: debug_agent_printf ?
I will change this.
> > +/* Print a formatted message to the appropriate channel for debugging
> > + output for the client. */
>
> IWBN to include mention that this function must be provided by the client.
> [I'm not sure what other similar decls do, but IWBN if they all had
> a similar comment.]
That's a good idea. I'll add this here and everywhere else that needs
it.
Thanks,
Gary
--
http://gbenson.net/
More information about the Gdb-patches
mailing list