[PATCH 03/11 v5] Move print-utils.h to common-defs.h
Gary Benson
gbenson@redhat.com
Wed Aug 6 17:05:00 GMT 2014
Doug Evans wrote:
> Gary Benson writes:
> > diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h
> > index 5543e4c..66c0d21 100644
> > --- a/gdb/common/common-defs.h
> > +++ b/gdb/common/common-defs.h
> > @@ -43,5 +43,6 @@
> > #include "gdb_assert.h"
> > #include "errors.h"
> > #include "common-types.h"
> > +#include "print-utils.h"
> >
> > #endif /* COMMON_DEFS_H */
>
> It's a bit odd to see common-defs.h include print-utils.h and not
> common-utils.h. I see it gets included by gdb_assert.h, but
> as a reader I'm still left with the question of wondering what's
> going on and wanting to spend time digging into it.
> I wonder if we can improve this somehow.
> [No need to work on that in this patch set though.]
This version of this series needs to be applied on top of this series:
https://sourceware.org/ml/gdb-patches/2014-07/msg00736.html
common-utils.h is moved into common-defs.h in patch 11 of that series
(and all other inclusions are removed, including the one in gdb_assert.h)
If it helps I have both series in a branch:
https://github.com/gbenson/binutils-gdb/tree/common-defs
Cheers,
Gary
--
http://gbenson.net/
More information about the Gdb-patches
mailing list