[PING] Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
Ian Lance Taylor
iant@google.com
Tue Apr 29 23:48:00 GMT 2014
On Tue, Apr 29, 2014 at 2:37 PM, John Marino <gnugcc@marino.st> wrote:
>
>> I don't understand the benefit of libgcc/enable-execute-stack-bsd.c.
>> The code seems the same as the existing
>> libgcc/enable-execute-stack-mprotect.c. All you are changing is
>> omitting need_enable_exec_stack. If you just drop the FreeBSD
>> constructor, you will get the behaviour you want.
>
> With the caveat that this patch is over 2 years old, I just took a look
> at both files. I would have not needed to modify this file at all for
> DragonFly. In fact, I seem to recall that I didn't modify it for
> DragonFly, but rather for FreeBSD. If I had to guess, it would be that
> I found mprotect() was needed regardless of value of kern.stackprot. I
> must have traced some test failures back to this.
>
> Which I guess that's what you mean - just delete the block between "#if
> defined __FreeBSD__" and the next #elif which should be equivalent. I
> can tweak the patch set to do that.
Yes.
> And what about the dl_iterate_phdr changes? Do they look good to you?
They looked fine to me but I'm not a build system maintainer.
Ian
More information about the Gdb-patches
mailing list