[patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.

[Pedro Alves]

Hi David,

No comments on the patch itself, just a nit.

On 04/13/2014 07:27 PM, David Blaikie wrote:
> gdb.cp/impl-this.exp is testing the ability to scope names within a
> class and includes cases where the base class was specified via a
> typedef.
> 
> Due to GCC's PR14819 these tests weren't actually testing this case -
> GCC produces the same debug info regardless of whether there's a
> typedef used in the base specifier.
> 
> Clang correctly produces the typedef debug info for the base type and
> exposes a variety of failures/limitations in these test cases.
> 
> The attached patch updates the tests to flag these cases as
> unsupported under GCC and xfail as appropriate under Clang.
> 
> 
> typedef_virtual_inheritance.diff
> 
> 
> commit 7fa92f9a15f440129dd5a989511f3bbda646afa5
> Author: David Blaikie <dblaikie@gmail.com>
> Date:   Sun Apr 13 11:15:44 2014 -0700
> 
>     Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.

I notice that the commit log doesn't have all the detail that your intro
above has.  Ideally the commit log would be complete as well.
I suggest not treating those as separate info at all, thus putting
all info in the commit log.  Then you can just use "git send-email"
to send the patches, even.

>     gdb/testsuite/
>     	* gdb.cp/impl-this.exp: Mark several tests XFAIL/UNSUPPORTED due to
>     	PR16841 and GCC PR60833

> -    gdb_test "print B<int>::A<int>::i" "Cannot reference non-static field \"i\""
> +    if {[test_compiler_info {gcc-*-*}]} {
> +        unsupported "gdb/16841"
> +    } else {
> +        setup_kfail gdb/x *-*-*

Thanks,
-- 
Pedro Alves