[patch] [gdb/testsuite] XFAIL under Clang tests using label debug info

Doug Evans dje@google.com
Wed Apr 23 22:03:00 GMT 2014


David Blaikie writes:
 > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a
 > bunch of GDB tests that rely on debug info for labels.
 > 
 > For some reason gdb.linespec/ls-expr.exp gathered all tests into a
 > dictionary and then ran them. This made it hard to XFAIL just the
 > right tests. I refactored this to execute the tests directly, removing
 > the dictionary so I could XFAIL the right tests. Is there a reason it
 > would've been written that way? Does my patch break it in some way?
 > commit c438cb16b63292e415330f289616c4e4ecece63c
 > Author: David Blaikie <dblaikie@gmail.com>
 > Date:   Sun Apr 13 11:42:02 2014 -0700
 > 
 >     XFAIL under Clang tests using labels
 >     
 >     gdb/testsuite/
 >     	* gdb.base/label.exp: XFAIL label related tests under Clang.
 >     	* gdb.cp/cplabel.exp: Ditto.
 >     	* gdb.linespec/ls-errs.exp: Refactor tests to execute directly
 >     	and XFAIL under Clang those using labels.

LGTM

 > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog
 > index 730c116..b04b940 100644
 > --- gdb/testsuite/ChangeLog
 > +++ gdb/testsuite/ChangeLog
 > @@ -1,3 +1,9 @@
 > +2014-04-12  David Blaikie  <dblaikie@gmail.com>
 > +
 > +        * gdb.base/label.exp: XFAIL label related tests under Clang.
 > +	* gdb.cp/cplabel.exp: Ditto.
 > +	* gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels.
 > +

Nit: space vs tabs.  Just use tabs.
Plus line is longer than 80 chars.



More information about the Gdb-patches mailing list