[RFA testsuite 3/5] Introduce mi_make_breakpoint

Tom Tromey tromey@redhat.com
Thu Apr 17 20:40:00 GMT 2014


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> 2014-04-15  Keith Seitz  <keiths@redhat.com>
Keith> 	* lib/mi-support.exp (mi_create_breakpoint): Use mi_make_breakpoint
Keith> 	and return the result.
Keith> 	(mi_make_breakpoint): New procedure.

One nit below.

Keith> +    parse_args {{number .*} {type .*} {disp .*} {enabled .*} {addr .*} \
Keith> +		    {func .*} {file .*} {fullname .*} {line .*} \
Keith> +		    {thread-groups \\\[.*\\\]} {times .*} {ignore 0} \
Keith> +		    {script ""} {original-location .*}}

I don't think the backslashes are needed at the ends of lines here.
The outer braces ought to be sufficient.

This is ok with this change.

Tom



More information about the Gdb-patches mailing list