[RFA] Fix c++/16597 (crash when inspecting lambda expression variables)

[Keith Seitz]

On 04/10/2014 09:58 AM, Tom Tromey wrote:
> First, we've checked in the original source file as a separate file, I
> think along with a note in the .exp about it.  This approach lets you
> avoid this:
>
> Keith> +# WARNING: This is hard-coded from the original source file! This
> Keith> +# breakpoint should be set inside the lambda in A::doit().
>
> ... since you can refer to comments in the original source file IIRC.

Aha! Yes, I see. I've made that change.

> Second, I think we've edited the compilation directory in the .S file,
> and maybe other little details as well (I had to edit the files to avoid
> 'main' for some reason I cannot remember):
>
> Keith> +.Linfo_string2:
> Keith> +	.asciz	 "/home/keiths/tmp/16597"

Ha ha. At least I didn't give away the farm! Alas, it isn't obvious to 
me why 'main' would cause problems -- several .S files contain 
references to that still.

I'm attaching the latest revision of this.

Keith

ChangeLog
2014-04-15  Keith Seitz  <keiths@redhat.com>

	PR c++/16597
	* cp-namespace.c (lookup_symbol_file): If the type name of
	`this' is NULL, return immediately.

testsuite/ChangeLog
2014-04-15  Keith Seitz  <keiths@redhat.com>

	PR c++/16597
	* gdb.cp/namelessclass.exp: New file.
	* gdb.cp/namelessclass.S: New file.
	* gdb.cp/namelessclass.cc: New file.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16597-2.patch
Type: text/x-patch
Size: 40626 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20140415/8e6ff2d5/attachment.bin>