[PATCH] [testsuite] Set target-charset to ascii

Joel Brobecker brobecker@adacore.com
Thu Apr 10 13:07:00 GMT 2014


Sorry about the wait, Yao.

> >> gdb/testsuite:
> >>
> >> 2014-03-25  Yao Qi  <yao@codesourcery.com>
> >>
> >> 	* lib/gdb.exp (with_target_charset): New proc.
> >> 	* gdb.base/printcmds.exp (test_print_all_chars): Wrap tests with
> >> 	with_target_charset.
> >> 	(test_print_strings): Likewise.
> >> 	(test_repeat_bytes): Likewise.
> >> 	* gdb.base/setvar.exp: Set target-charset to ASCII temporarily
> >> 	for some tests.

I'm a little unsure about this one, because I am not sure that all
targets will support the "ASCII" charset. For instance, I logged on
a Tru64 machine, and "local -a" only returned:

    POSIX
    en_US.ISO8859-1

On the other hand, a GDB built with libiconv supports ASCII (and much
more). So I'm inclined to try your patch. Give it another couple of
days, and if noone objects, then go ahead and commit.

-- 
Joel



More information about the Gdb-patches mailing list