[PATCH] Get frame after pull single-step breakpoints out

Yao Qi yao@codesourcery.com
Thu Apr 10 03:49:00 GMT 2014


This patch fixes the fails I saw on nios2-linux testing.  Thanks.

On 04/04/2014 08:49 PM, Pedro Alves wrote:
> This is actually one thing that my v1 of the recent
> "fix a bunch of run control bugs" series was fixing, because
> it made sss breakpoints be regular breakpoints in the breakpoint
> chain.  But I had to drop that in v2.
> 
> For all kinds of breakpoints breakpoint_xfer_memory hides the
> breakpoint instructions, but sss breakpoints aren't tracked like all
> other breakpoints.
> 
> So instead of making sss breakpoints regular breakpoints, go with
> a simpler fix (at least for now) -- make breakpoint_xfer_memory
> take software single-step breakpoints into account.  Something
> like the patch below.  After the patch, I get the correct
> disassemble output.

This will be complicated when we need per-thread software single step
breakpoint.  IIRC, 'run all-stop mode on top of non-stop target' needs
it.

The problem is sss breakpoint is there when frame unwinder sniffer
reads memory.  Your fix is to make sss breakpoint invisible, while mine
is pull sss breakpoint out before sniffer reads memory.  I can't see
anything wrong with my patch.  It is simple, and are you OK to consider
it?

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list