vdso handling
Alan Modra
amodra@gmail.com
Wed Apr 2 01:50:00 GMT 2014
On Tue, Apr 01, 2014 at 02:46:38PM +0100, Pedro Alves wrote:
> On 03/28/2014 11:00 PM, Alan Modra wrote:
>
> > I believe the intent of rounding to a page was to pick up the file
> > and program headers at the start of a file and section headers at the
> > end, so let's do just that. On top of my last patch:
>
> Agreed. This works for me. Thanks!
>
> > - if (i_phdrs[i].p_align > 1)
> > + /* Extend the beginning of the first pt_load to cover file
> > + header and program headers. */
> > + if (first_phdr == &i_phdrs[i])
>
> Minor nit: Perhaps the comment could say "first pt_load
> if it covers offset 0"?
Fixed.
/* Extend the beginning of the first pt_load to cover file
header and program headers, if we proved earlier that its
aligned offset is 0. */
> Please don't use ATTRIBUTE_UNUSED under gdb/, it'd be flagged by the
> ARI as a regression:
Hmm, OK. Fixed and pushed.
--
Alan Modra
Australia Development Lab, IBM
More information about the Gdb-patches
mailing list