[PATCH 1/6] Move notif_queue to remote_state

Pedro Alves palves@redhat.com
Mon Sep 30 17:08:00 GMT 2013


On 09/30/2013 08:33 AM, Yao Qi wrote:

> -/* Process notifications one by one.  EXCEPT is not expected in
> -   the queue.  */
> +/* Process notifications in in STATE's notification queue one by one.

double "in"

> +   EXCEPT is not expected in the queue.  */

>  void
> -remote_notif_process (struct notif_client *except)
> +remote_notif_process (struct remote_notif_state *state,
> +		      struct notif_client *except)
>  {


> +DECLARE_QUEUE_P (notif_client_p);
> +
> +/* State on remote async notification.  */
> +
> +struct remote_notif_state
> +{
> +  /* Notification queue.  */
> +  QUEUE(notif_client_p) *notif_queue;
> +
> +  /* Asynchronous signal handle registered as event loop source for when
> +     the remote sent us a notification.  The registered callback
> +     will do a ACK sequence to pull the rest of the events out of
> +     the remote side into our event queue.  */
> +
> +  struct async_event_handler *remote_async_get_pending_events_token;

Inconsistent "empty line between describing comment and field".

> -static void
> -notif_xfree (struct notif_client *notif)
...
> -  if (notif->pending_event != NULL
> -      && notif->pending_event->dtr != NULL)
> -    notif->pending_event->dtr (notif->pending_event);

Hmm, it's not clear to me from reading the patch where is
pending_event released after this patch.  Could you help
me understand that?

-- 
Pedro Alves



More information about the Gdb-patches mailing list