[v15 0/5] remove-symbol-file & add-symbol-file

Thu Sep 26 17:06:00 GMT 2013

Hi,

Check-in '51c92d0 Code cleanup: Add objfile_name accessor' broke the first patch
of this series (New remove-symbol-file command) because it removed 'objfile->name'.
One need to write now 'objfile_name (objfile)' to get the name of an objfile.

The change is trivial. I am sending the complete series again so that people
interested in this feature can download it more easily. The patch set was tested
on amd64 and x32.

I would love to hear back from maintainers if this is a feature they would
consider merging at some point.

Regards,

Nicolas

Changes in v15

* symfile.c (remove_symbol_file_command): Reflect modification of struct objfile
  from upstream ("objf->name" => "objfile_name (objf)").

Changes in v14

* symfile.c (add_target_sections_of_objfile): Reflect modification
  of struct target_section from upstream.
  (symfile_free_objfile): Reflect modification of struct target_section
  from upstream.

Changes in v13

* Changed "is_elf_target" to "is_known_elf_target" (Patch 4/5)
  according to Doug's proposal
  (http://sourceware.org/ml/gdb-patches/2013-07/msg00426.html).

* Removed dependency to <elf.h> according to Mark's suggestion
  (http://sourceware.org/ml/gdb-patches/2013-07/msg00415.html).

Changes in v12

* symfile.c (add_target_sections_of_objfile): Reflect modification
  of struct target_section from upstream.

* gdb.base/sym-file-main.c: Move loader into a separate file as suggested
  and implemented the other recommendations from Doug.

* gdb.base/sym-file-loader.c: New file.

* gdb.base/sym-file-loader.h: New file.

* lib/gdb.exp (is_elf_target): New function.

Changes in v11

* Changed documentation for add-symbol-file according to feedback (Patch 3):
  "keeps adding to" -> "is kept in addition to".

* Fixed indentation issues in test (sym-file-main.c from Patch 2).

Changes in v10

* Dropped "USAGE" in "USAGE: remove-symbol-file FILENAME" according to suggestion.

* Fixed comment according to suggestion:
  "any reference to any objfile" -> "all references to any objfile"

* Added argument names to the prototype of is_addr_in_objfile according to suggestion.

* Fixed indentation of "macro" loops according to feedback.

* Fixed indentation issues.

Changes in v9

* Patch 4: New patch (fix  add-symbol-file for 'info files').
* Patch 5: New patch (test add-symbol-file and 'info files');

* sym-file.exp: Fixed test name string.

Changes in v8

* sym-file.exp: Call gdb_get_line_number with ${libfile}.c intead of $libsrc.

* Fixed typo in commit message for Patch 2/3.

Changes in v7

* Changed disable_breakpoints_in_freed_objfile () from feedback:
  Use is_breakpoint () and is_tracepoint ().
  Add call to mark_breakpoint_location_modified ().

* Changed command description according to suggestion.

* Changed commit log message for new functions according to feedback.

* Fixed nits in gdb/solib.c and testsuite/gdb.base/sym-file.exp.

Changes in v6

* Changed syntax of the command according to feedback:
    remove-symbol-file FILENAME
    remove-symbol-file -a ADDRESS

* Updated the documentation for the new syntax.

* Updated the test for the new syntax.

* Added check to only remove objfiles from the current program space.

Changes in v5

* The address parameter can now be any address mapping into one of the sections
  of the file to remove. This is more flexible and more judicious because the symbol
  file may have no text section, as pointed out in some reviews.

* Move is_addr_in_objfile from breakpoint.c to objfiles.c. This new function
  is now used in both symfile.c and breakpoint.c.

* is_addr_in_objfile returns now 0 if OBJFILE is NULL.

* Updated the documentation to reflect the command change.

* Removed double blank lines.

* Reworded the log entries in the commit messages, as suggested.

* The test was simplified using prepare_for_testing, as suggested.

Changes in v4

* gdb/symfile.c: add missing space character in output string.

* gdb/doc/gdb.texinfo: add usage example.

Changes in v3

* gdb/breakpoints.c (disable_breakpoints_in_freed_objfile):
  Changed name of disable_breakpoints_in_free_objfile to disable_breakpoints_in_freed_objfile.
  Call observer_breakpoint_modified at most one time per breakpoint.

* gdb/objfiles.h (struct objfile): Add comment for low_addr.

* gdb/solib.c (remove_user_added_objfile): Don't check OBJF_SHARED anymore to avoid leaving dangling pointers.

* gdb/symfile.c (add_symbol_file_command): Parse and evaluate the address parameter only once.

* gdb/symfile.c (remove_symbol_file_command): Don't use gdb_buildargv anymore. Ask the user for confirmation before removing a file.

* gdb/doc/gdb.texinfo: The parameter of the command is now referred to as "the address of the text section".

* gdb/NEWS: Move the entry for remove-symbol-file to "Changes since GDB 7.6". The address parameter is now referred to as "the beginning of the text section".

* Fixed letter case of variables in comments.

* Fixed indentation typos.

Nicolas Blanc (5):
  New remove-symbol-file command.
  Documentation for the remove-symbol-file command.
  'add-symbol-file' should update the current target sections.
  Function is_known_elf_target.
  Test adding and removing a symbol file at runtime.

 gdb/NEWS                                 |    6 +
 gdb/breakpoint.c                         |   67 ++++++-
 gdb/doc/gdb.texinfo                      |   26 ++-
 gdb/doc/observer.texi                    |    4 +
 gdb/objfiles.c                           |   23 ++
 gdb/objfiles.h                           |    2 +
 gdb/printcmd.c                           |   15 +-
 gdb/solib.c                              |   22 ++
 gdb/symfile.c                            |  150 +++++++++++++-
 gdb/testsuite/gdb.base/sym-file-lib.c    |   26 +++
 gdb/testsuite/gdb.base/sym-file-loader.c |  353 ++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.base/sym-file-loader.h |   99 +++++++++
 gdb/testsuite/gdb.base/sym-file-main.c   |   79 +++++++
 gdb/testsuite/gdb.base/sym-file.exp      |  160 ++++++++++++++
 gdb/testsuite/lib/gdb.exp                |   15 ++
 15 files changed, 1034 insertions(+), 13 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file-loader.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file-loader.h
 create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file.exp

-- 
1.7.6.5