[RFC] PR 15873 UTF-8 incoplete/invalid chars go unnoticed

Yao Qi yao@codesourcery.com
Fri Sep 20 03:07:00 GMT 2013


On 08/21/2013 10:55 PM, Pierre Muller wrote:
>    This test was failing a lot for mingw built GDB,
> and while trying to understand why this was not the case on linux,
> I noticed that the test was only completing successfully because
> UTF-8 is the default target-charset on the linux system I tested.

Pierre,
Yes, I saw these fails too.  I build GDB with and without libiconv,
these fails are there.  I spent some time on it, but had no clue so far.
Looks like it is about encoding conversion, but I don't have any
knowledge on it.

>    The patch below adds a <invalid>/<incomplete> marker
> to 1-byte chars that are not valid in UTF-8.
>
>    This means that this patch will create regressions
> in testsuite runs, but I think that it's the
> test that is wrong, not my patch.

What is the point of this patch?  We usually post patch to fix a certain 
bug.  If we are unable to fix them, we can open a PR (like what you 
did), and copy all the fails in the PR to track them.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list