[patch][python] Fix Python 3 long/int logic error when converting a value in GDB

Tom Tromey tromey@redhat.com
Wed Sep 18 20:01:00 GMT 2013


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I audited the code for other checks like this and found these files
Phil> use PyInt_Check.

Thank you.

Phil> Of those, the only check that makes a differentiation between a long
Phil> and an int is py-arch.c.  The order for that check is already correct,
Phil> so no change is needed.  The other files just do a simple number
Phil> check, and those work as intended.

Phil> OK?

I think that since the code is sensitive to the ordering, and since
we've already made an error here, it would be best to add an explanatory
comment at the two sites where it matters.

Tom



More information about the Gdb-patches mailing list