[patchv3 1/5] Mostly code cleanup: Constification

Jan Kratochvil jan.kratochvil@redhat.com
Tue Sep 17 19:37:00 GMT 2013


On Tue, 17 Sep 2013 21:32:48 +0200, Tom Tromey wrote:
> >>>>> "Doug" == Doug Evans <dje@google.com> writes:
> 
> Doug> What's wrong with utility wrappers?
> 
> In the general case they require the introduction of a new function, a
> new type, and marshalling and unmarshalling code.  This is verbose and
> error prone.
> 
> I suppose catch_command_errors* aren't quite so bad.

* catch_command_errors* use non-public function print_any_exception() with
  unclear differences from the public function exception_print().

* The body of catch_command_errors* is several lines of code which is rather
  questionable whether it is worth wrapping in a function.

But I sure do not mind much either way, primarily it should be converted to
C++ try {} before the discussion makes sense to continue.


Jan



More information about the Gdb-patches mailing list