[patchv3 1/5] Mostly code cleanup: Constification

Jan Kratochvil jan.kratochvil@redhat.com
Tue Sep 17 06:48:00 GMT 2013


On Tue, 17 Sep 2013 00:22:12 +0200, Doug Evans wrote:
> Jan Kratochvil writes:
>  > -	catch_command_errors (symbol_file_add_main, symarg,
>  > -			      !batch_flag, RETURN_MASK_ALL);
>  > +	{
>  > +	  volatile struct gdb_exception e;
>  > +
>  > +	  TRY_CATCH (e, RETURN_MASK_ALL)
>  > +	    {
>  > +	      symbol_file_add_main (symarg, !batch_flag);
>  > +	    }
>  > +	  exception_print (gdb_stderr, e);
>  > +	}
>  >      }
>  >  
>  >    if (corearg && pidarg)
> 
> There is catch_command_errors_const.
> Would that work here?

It would work here.  But I thought catch_command_errors* is deprecated in
favor of TRY_CATCH.  Maybe I could split this patch in two, but the end would
be the same.


Jan



More information about the Gdb-patches mailing list