[patch][python] Fix python/14513

Tom Tromey tromey@redhat.com
Mon Oct 21 21:58:00 GMT 2013


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I am not sure what the resolution is here.  At some point we have to
Phil> decide whether we have anything valid to print.  We can hoist the
Phil> fprint into both of these branches, but even in the "else" clause we
Phil> have to check if we actually have anything as the fprint adds a
Phil> newline to the set documentation:

Phil> fprintf_filtered (gdb_stdout, "%s\n", set_doc_string);

Phil> What are your thoughts on this?

I've been thinking about it more and I don't understand why we want to
print anything in the "set" command.
I think it's fine if we just don't call a method.
What do you think of that?

Tom



More information about the Gdb-patches mailing list