[PATCH v2 1/9] introduce minimal_symbol_upper_bound
Doug Evans
dje@google.com
Mon Oct 21 16:47:00 GMT 2013
On Mon, Oct 21, 2013 at 9:23 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> When I read the comment "Try ..." I'm left with asking "What if the
> Doug> attempt fails?".
> Doug> Maybe remove the words "Try to" and be clearer about what the result
> Doug> is if a heuristic is needed?
>
> I changed it to read:
>
> /* Compute the upper bound of MINSYM. The upper bound is the last
> address thought to be part of the symbol. If the symbol has a
> size, it is used. Otherwise use the lesser of the next minimal
> symbol in the same section, or the end of the section, as the end
> of the function. */
>
> Let me know what you think.
LGTM
More information about the Gdb-patches
mailing list