[RFA/code+NEWS] new "set/show serial baud" command (was: "Re: Setting parity for remote serial")

Joel Brobecker brobecker@adacore.com
Tue Oct 8 14:16:00 GMT 2013


> > I'd rather we do it right the first time. If we're a go with
> > the "set serial baud" command, I don't mind taking care of
> > that part. As Pedro hints, it's a fairly easy change to make.
> > 
> > Pedro, should we go ahead? It's only been a day or two, but we haven't
> > had any objection so far.
> 
> Yeah, I think so.

Attached is a patch that implements that.

gdb/ChangeLog:

        * cli/cli-cmds.c (show_baud_rate): Moved to serial.c as
        serial_baud_show_cmd.
        (_initialize_cli_cmds): Delete the code creating the
        "set/show remotebaud" commands.
        * serial.c (baud_rate): Move here from top.c.
        (serial_baud_show_cmd): Move here from cli/cli-cmds.c.
        (_initialize_serial): Create "set/show serial baud" commands.
        Add "set/show remotebaud" command aliases.
        * top.c (baud_rate): Moved to serial.c.
        * NEWS: Document the new "set/show serial baud" commands,
        replacing "set/show remotebaud".

Tested on x86_64-linux, with no regression (I almost expected one,
as we used to test thhe output "help set", or soemthing like that).

OK to commit?

Thanks,
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Rename-set-show-remotebaud-command-into-set-show-ser.patch
Type: text/x-diff
Size: 5873 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20131008/411d5ab6/attachment.bin>


More information about the Gdb-patches mailing list