[RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar

Keith Seitz keiths@redhat.com
Tue Oct 1 01:19:00 GMT 2013


On 09/26/2013 01:03 PM, Pierre Muller wrote:

> 2013-09-26  Pierre Muller  <muller@sourceware.org>
>
>   	valprint.c (print_wchar): Honor sevenbit_strings value.
>

[Your ChangeLog entry got munged...] I would prefer that you ChangeLog 
entry be a little more explicit about what changed, e.g., "Print escaped 
characters if sevenbit-strings is set."

I think this patch is okay, but it definitely needs a test (and a 
maintainer to approve). It took me a non-trivial amount of time to 
actually get the patch to show any difference in the output.

The trick (on linux) was changing the charset to something where 
(char)0x80 and up are printable characters. I used CP1252, and then I 
could see what this patch actually did.

Perhaps this can be used in a test that will run on more than just MinGW 
hosts.

Keith



More information about the Gdb-patches mailing list