[PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet

Pedro Alves palves@redhat.com
Fri Nov 29 16:05:00 GMT 2013


On 11/28/2013 09:07 AM, Hui Zhu wrote:

> +  if (have_target_target_side_commands)

This can now just be:

  if (!VEC_empty (agent_expr_p, bp_tgt->tcommands))

OK with that change.

> +    {
> +      warning (_("\
> +Target doesn't support breakpoints that have target side commands."));

I was doing to suggest making this an error instead, that
insert_bp_location would print the error string, but that's
only true for hw breakpoints... insert_bp_location's error
handling is quite messy.  For instance, if this breakpoint
is in a a shared library, this will disable the breakpoint,
even though the cause of the error is clearly not that the
shared library disappeared (i.e., not a memory error).

> +      return -1;
> +    }
-- 
Pedro Alves



More information about the Gdb-patches mailing list